[PATCH net-next] vrf: fix NULL dereference in vrf_finish_output()

Subsystems: networking drivers, the rest, vrf

STALE1824d LANDED

Landed in mainline as 06669e6880be on 2021-08-06.

2 messages, 2 authors, 2021-08-06 · open the first message on its own page

[PATCH net-next] vrf: fix NULL dereference in vrf_finish_output()

From: Dan Carpenter <hidden>
Date: 2021-08-06 15:04:57

The "skb" pointer is NULL on this error path so we can't dereference it.
Use "dev" instead.

Fixes: 14ee70ca89e6 ("vrf: use skb_expand_head in vrf_finish_output")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/vrf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
index 726adf07ef31..662e26117353 100644
--- a/drivers/net/vrf.c
+++ b/drivers/net/vrf.c
@@ -864,7 +864,7 @@ static int vrf_finish_output(struct net *net, struct sock *sk, struct sk_buff *s
 	if (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) {
 		skb = skb_expand_head(skb, hh_len);
 		if (!skb) {
-			skb->dev->stats.tx_errors++;
+			dev->stats.tx_errors++;
 			return -ENOMEM;
 		}
 	}
-- 
2.20.1

Re: [PATCH net-next] vrf: fix NULL dereference in vrf_finish_output()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-06 22:50:07

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 6 Aug 2021 18:04:35 +0300 you wrote:
The "skb" pointer is NULL on this error path so we can't dereference it.
Use "dev" instead.

Fixes: 14ee70ca89e6 ("vrf: use skb_expand_head in vrf_finish_output")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/vrf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - [net-next] vrf: fix NULL dereference in vrf_finish_output()
    https://git.kernel.org/netdev/net-next/c/06669e6880be

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help