Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test

Hello,

On Thu, 2021-08-05 at 13:17 -0700, Coco Li wrote:

quoted

Have you considered additionally run the same test of top of a veth
pair, and have such tests always enabled, so we could have some
coverage regardless of specific H/W available?

quoted

To do the above you should disable TSO on the veth sender peer and
enable GRO on the other end.

Thanks for the suggestion! To make sure I understand you correctly,
would this be another script that creates the veth pair separate from
the gro.sh wrapper?

I personally don't have any strict preference. I *think* the veth
thing could still fit the gro.sh script, but whatever is easier coding
wise would fit. 

The gro.sh script with no/default argument could run all the tests on a
veth pair; if a device name is specified via the command line, it could
additionally run (the specified set of tests) on such device.

Cheers,

Paolo

Sounds good! I'll work on a follow up patch.

Best,
Coco