[PATCH net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE1853d

2 messages, 2 authors, 2021-08-03 · open the first message on its own page

[PATCH net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu

From: Antoine Tenart <atenart@kernel.org>
Date: 2021-08-03 10:00:20

The patch fixing the returned value of ip6_skb_dst_mtu (int -> unsigned
int) was rebased between its initial review and the version applied. In
the meantime fade56410c22 was applied, which added a new variable (int)
used as the returned value. This lead to a mismatch between the function
prototype and the variable used as the return value.

Fixes: 40fc3054b458 ("net: ipv6: fix return value of ip6_skb_dst_mtu")
Cc: Vadim Fedorenko <redacted>
Signed-off-by: Antoine Tenart <atenart@kernel.org>
---
 include/net/ip6_route.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
index 625a38ccb5d9..0bf09a9bca4e 100644
--- a/include/net/ip6_route.h
+++ b/include/net/ip6_route.h
@@ -265,7 +265,7 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
 
 static inline unsigned int ip6_skb_dst_mtu(struct sk_buff *skb)
 {
-	int mtu;
+	unsigned int mtu;
 
 	struct ipv6_pinfo *np = skb->sk && !dev_recursion_level() ?
 				inet6_sk(skb->sk) : NULL;
-- 
2.31.1

Re: [PATCH net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-03 12:00:12

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue,  3 Aug 2021 12:00:16 +0200 you wrote:
The patch fixing the returned value of ip6_skb_dst_mtu (int -> unsigned
int) was rebased between its initial review and the version applied. In
the meantime fade56410c22 was applied, which added a new variable (int)
used as the returned value. This lead to a mismatch between the function
prototype and the variable used as the return value.

Fixes: 40fc3054b458 ("net: ipv6: fix return value of ip6_skb_dst_mtu")
Cc: Vadim Fedorenko <redacted>
Signed-off-by: Antoine Tenart <atenart@kernel.org>

[...]
Here is the summary with links:
  - [net] net: ipv6: fix returned variable type in ip6_skb_dst_mtu
    https://git.kernel.org/netdev/net/c/4039146777a9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help