[PATCH v2] bcm63xx_enet: delete a redundant assignment

Subsystems: networking drivers, the rest

STALE1851d

3 messages, 3 authors, 2021-07-29 · open the first message on its own page

[PATCH v2] bcm63xx_enet: delete a redundant assignment

From: Tang Bin <hidden>
Date: 2021-07-29 04:02:46

In the function bcm_enetsw_probe(), 'ret' will be assigned by
bcm_enet_change_mtu(), so 'ret = 0' make no sense.

Signed-off-by: Zhang Shengju <redacted>
Signed-off-by: Tang Bin <redacted>
---
Changes from v1
 - fix up the subject
---
 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 916824cca..509e10013 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2646,7 +2646,6 @@ static int bcm_enetsw_probe(struct platform_device *pdev)
 	if (!res_mem || irq_rx < 0)
 		return -ENODEV;
 
-	ret = 0;
 	dev = alloc_etherdev(sizeof(*priv));
 	if (!dev)
 		return -ENOMEM;
-- 
2.20.1.windows.1


Re: [PATCH v2] bcm63xx_enet: delete a redundant assignment

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-07-29 04:15:56


On 7/28/2021 9:03 PM, Tang Bin wrote:
In the function bcm_enetsw_probe(), 'ret' will be assigned by
bcm_enet_change_mtu(), so 'ret = 0' make no sense.

Signed-off-by: Zhang Shengju <redacted>
Signed-off-by: Tang Bin <redacted>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH v2] bcm63xx_enet: delete a redundant assignment

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-07-29 21:20:08

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 29 Jul 2021 12:03:00 +0800 you wrote:
In the function bcm_enetsw_probe(), 'ret' will be assigned by
bcm_enet_change_mtu(), so 'ret = 0' make no sense.

Signed-off-by: Zhang Shengju <redacted>
Signed-off-by: Tang Bin <redacted>
---
Changes from v1
 - fix up the subject

[...]
Here is the summary with links:
  - [v2] bcm63xx_enet: delete a redundant assignment
    https://git.kernel.org/netdev/net-next/c/3e12361b6d23

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help