# Re: \[PATCH net-next v3 27/31\] dev\_ioctl: split out ndo\_eth\_ioctl

- From: Jason Gunthorpe \<jgg@nvidia.com\>
- Date: 2021-07-27 16:30:30 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/07/1459772
- Thread: https://ratatoskr.run/netdev/2021/07/1459546/t.md

```text
On Tue, Jul 27, 2021 at 03:45:13PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Most users of ndo_do_ioctl are ethernet drivers that implement
> the MII commands SIOCGMIIPHY/SIOCGMIIREG/SIOCSMIIREG, or hardware
> timestamping with SIOCSHWTSTAMP/SIOCGHWTSTAMP.
> 
> Separate these from the few drivers that use ndo_do_ioctl to
> implement SIOCBOND, SIOCBR and SIOCWANDEV commands.
> 
> This is a purely cosmetic change intended to help readers find
> their way through the implementation.
> 
> Cc: Doug Ledford <redacted>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Jay Vosburgh <redacted>
> Cc: Veaceslav Falico <redacted>
> Cc: Andy Gospodarek <andy@greyhouse.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Vivien Didelot <redacted>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: <redacted>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>  Documentation/networking/netdevices.rst       |  4 ++
>  Documentation/networking/timestamping.rst     |  6 +--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c     |  8 ++--

Acked-by: Jason Gunthorpe <jgg@nvidia.com>

ipoib is a convoluted, but this transform looks OK

Jason
```
