From: Georgi Valkov <hidden> Date: 2021-07-20 09:45:03
ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
https://github.com/openwrt/openwrt/pull/4084
From dd109ded2b526636fff438d33433ab64ffd21583 Mon Sep 17 00:00:00 2001
From: Georgi Valkov <redacted>
Date: Fri, 16 Apr 2021 20:44:36 +0300
Subject: [PATCH] ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
When rx_buf is allocated we need to account for IPHETH_IP_ALIGN,
which reduces the usable size by 2 bytes. Otherwise we have 1512
bytes usable instead of 1514, and if we receive more than 1512
bytes, ipheth_rcvbulk_callback is called with status -EOVERFLOW,
after which the driver malfunctiones and all communication stops.
Fixes: ipheth 2-1:4.2: ipheth_rcvbulk_callback: urb status: -75
Signed-off-by: Georgi Valkov <redacted>
---
drivers/net/usb/ipheth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
On Tue, Jul 20, 2021 at 12:37:43PM +0300, Georgi Valkov wrote:
ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
https://github.com/openwrt/openwrt/pull/4084
From dd109ded2b526636fff438d33433ab64ffd21583 Mon Sep 17 00:00:00 2001
From: Georgi Valkov <redacted>
Date: Fri, 16 Apr 2021 20:44:36 +0300
Subject: [PATCH] ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
When rx_buf is allocated we need to account for IPHETH_IP_ALIGN,
which reduces the usable size by 2 bytes. Otherwise we have 1512
bytes usable instead of 1514, and if we receive more than 1512
bytes, ipheth_rcvbulk_callback is called with status -EOVERFLOW,
after which the driver malfunctiones and all communication stops.
Fixes: ipheth 2-1:4.2: ipheth_rcvbulk_callback: urb status: -75
Signed-off-by: Georgi Valkov <redacted>
---
drivers/net/usb/ipheth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-07-20 10:24:04
On Tue, 20 Jul 2021 12:37:43 +0300, Georgi Valkov wrote:
ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
https://github.com/openwrt/openwrt/pull/4084
From dd109ded2b526636fff438d33433ab64ffd21583 Mon Sep 17 00:00:00 2001
From: Georgi Valkov <redacted>
Date: Fri, 16 Apr 2021 20:44:36 +0300
Subject: [PATCH] ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
This is all unnecessary, IIUC you're submitting this patch for upstream
inclusion, please rebase it on the netdev/net tree, and try git
send-email on a file generated by git format-patch. Before that please
correct the fixes tag to the common format (you'll find it in docs or
follow what others do).
From: Georgi Valkov <hidden> Date: 2021-07-20 11:40:37
I am doing this for the first time, so any help would be appreciated!
What is to rebase on the netdev/net tree? The patch from my previous e-mail was
generated by `git format-patch -1`. I can’t notice any difference when compared to
to the newly generated patch, which I rebased on the latest master.
According to the description from the link below, I ran the following commands:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#providing-base-tree-information
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
cd linux
git checkout -t -b ipheth-fix-RX-EOVERFLOW master
git am --signoff < 0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
git format-patch --base=auto --cover-letter -o drivers/net/ master
drivers/net/0000-cover-letter.patch
From cd18496373e28af570dc382f618edd442d705252 Mon Sep 17 00:00:00 2001
From: Georgi Valkov <redacted>
Date: Tue, 20 Jul 2021 14:15:58 +0300
Subject: [PATCH 0/1] *** SUBJECT HERE ***
*** BLURB HERE ***
Georgi Valkov (1):
ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
drivers/net/usb/ipheth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
base-commit: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c
--
2.32.0
drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
From cd18496373e28af570dc382f618edd442d705252 Mon Sep 17 00:00:00 2001
From: Georgi Valkov <redacted>
Date: Fri, 16 Apr 2021 20:44:36 +0300
Subject: [PATCH 1/1] ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
When rx_buf is allocated we need to account for IPHETH_IP_ALIGN,
which reduces the usable size by 2 bytes. Otherwise we have 1512
bytes usable instead of 1514, and if we receive more than 1512
bytes, ipheth_rcvbulk_callback is called with status -EOVERFLOW,
after which the driver malfunctiones and all communication stops.
Fixes: ipheth 2-1:4.2: ipheth_rcvbulk_callback: urb status: -75
Signed-off-by: Georgi Valkov <redacted>
---
drivers/net/usb/ipheth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.32.0
My patch corrects the following commit, which changes IPHETH_BUF_SIZE from 1516 to 1514:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/usb/ipheth.c?id=f33d9e2b48a34e1558b67a473a1fc1d6e793f93c
> On 2021-07-20, at 1:22 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 20 Jul 2021 12:37:43 +0300, Georgi Valkov wrote:
>> ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
>> https://github.com/openwrt/openwrt/pull/4084
>>
>>
>> From dd109ded2b526636fff438d33433ab64ffd21583 Mon Sep 17 00:00:00 2001
>> From: Georgi Valkov <gvalkov@abv.bg>
>> Date: Fri, 16 Apr 2021 20:44:36 +0300
>> Subject: [PATCH] ipheth: fix EOVERFLOW in ipheth_rcvbulk_callback
>
> This is all unnecessary, IIUC you're submitting this patch for upstream
> inclusion, please rebase it on the netdev/net tree, and try git
> send-email on a file generated by git format-patch. Before that please
> correct the fixes tag to the common format (you'll find it in docs or
> follow what others do).
>
On Tue, Jul 20, 2021 at 02:39:49PM +0300, Georgi Valkov wrote:
I am doing this for the first time, so any help would be appreciated!
Have you read Documentation/process/submitting-patches.rst yet? If not,
please do so.
And look at examples on this list, you have to send individual patches,
not everything all crammed into one email.
thanks,
greg k-h
From: Georgi Valkov <hidden> Date: 2021-07-20 12:47:19
Yes, I read it, and before my previous e-mail that I also read the link from Jakub,
which essentially provides the same information.
There is only one patch 0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
The command I used from the example also generated a 0000-cover-letter, so
I included it as well.
I still have no clue what exactly I should do. Can you please help me?
Georgi Valkov
On 2021-07-20, at 2:49 PM, Greg KH [off-list ref] wrote:
On Tue, Jul 20, 2021 at 02:39:49PM +0300, Georgi Valkov wrote:
quoted
I am doing this for the first time, so any help would be appreciated!
Have you read Documentation/process/submitting-patches.rst yet? If not,
please do so.
And look at examples on this list, you have to send individual patches,
not everything all crammed into one email.
thanks,
greg k-h
On Tue, Jul 20, 2021 at 03:46:11PM +0300, Georgi Valkov wrote:
Yes, I read it, and before my previous e-mail that I also read the link from Jakub,
which essentially provides the same information.
There is only one patch 0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
Great, send that using 'git send-email' and all is good.
The command I used from the example also generated a 0000-cover-letter, so
I included it as well.
Why do you need a cover letter for 1 patch?
thanks,
greg k-h
From: Georgi Valkov <hidden> Date: 2021-07-20 13:14:05
Thank you, Greg!
git send-email drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
...
Result: OK
I hope I got right. I added most of the e-mail addresses, and also tried adding Message-Id.
I have not received the e-mail yet, so I cannot confirm if it worked or not.
Georgi Valkov
On 2021-07-20, at 3:54 PM, Greg KH [off-list ref] wrote:
On Tue, Jul 20, 2021 at 03:46:11PM +0300, Georgi Valkov wrote:
quoted
Yes, I read it, and before my previous e-mail that I also read the link from Jakub,
which essentially provides the same information.
There is only one patch 0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
Great, send that using 'git send-email' and all is good.
quoted
The command I used from the example also generated a 0000-cover-letter, so
I included it as well.
Why do you need a cover letter for 1 patch?
thanks,
greg k-h
From: Jan Kiszka <jan.kiszka@siemens.com> Date: 2022-01-31 09:45:35
Hi Georgi,
On 20.07.21 15:12, Georgi Valkov wrote:
Thank you, Greg!
git send-email drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
...
Result: OK
I hope I got right. I added most of the e-mail addresses, and also tried adding Message-Id.
I have not received the e-mail yet, so I cannot confirm if it worked or not.
What happened here afterwards?
I just found out the hard way that this patch is still not in mainline
but really needed.
Thanks,
Jan
quoted
On 2021-07-20, at 3:54 PM, Greg KH [off-list ref] wrote:
On Tue, Jul 20, 2021 at 03:46:11PM +0300, Georgi Valkov wrote:
quoted
Yes, I read it, and before my previous e-mail that I also read the link from Jakub,
which essentially provides the same information.
There is only one patch 0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
Great, send that using 'git send-email' and all is good.
quoted
The command I used from the example also generated a 0000-cover-letter, so
I included it as well.
Why do you need a cover letter for 1 patch?
thanks,
greg k-h
--
Siemens AG, Technology
Competence Center Embedded Linux
From: Jakub Kicinski <kuba@kernel.org> Date: 2022-01-31 17:27:31
On Mon, 31 Jan 2022 10:45:23 +0100 Jan Kiszka wrote:
On 20.07.21 15:12, Georgi Valkov wrote:
quoted
Thank you, Greg!
git send-email drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
...
Result: OK
I hope I got right. I added most of the e-mail addresses, and also tried adding Message-Id.
I have not received the e-mail yet, so I cannot confirm if it worked or not.
What happened here afterwards?
I just found out the hard way that this patch is still not in mainline
but really needed.
From: Jan Kiszka <jan.kiszka@siemens.com> Date: 2022-01-31 17:35:51
On 31.01.22 18:27, Jakub Kicinski wrote:
On Mon, 31 Jan 2022 10:45:23 +0100 Jan Kiszka wrote:
quoted
On 20.07.21 15:12, Georgi Valkov wrote:
quoted
Thank you, Greg!
git send-email drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
...
Result: OK
I hope I got right. I added most of the e-mail addresses, and also tried adding Message-Id.
I have not received the e-mail yet, so I cannot confirm if it worked or not.
What happened here afterwards?
I just found out the hard way that this patch is still not in mainline
but really needed.
I have not seen the repost :(
Would it help if I do that on behalf of Georgi? Meanwhile, I can add a
tested-by to it, after almost a full working day with it applied.
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
From: Georgi Valkov <hidden> Date: 2022-01-31 21:52:50
On 2022-01-31, at 7:35 PM, Jan Kiszka [off-list ref] wrote:
On 31.01.22 18:27, Jakub Kicinski wrote:
quoted
On Mon, 31 Jan 2022 10:45:23 +0100 Jan Kiszka wrote:
quoted
On 20.07.21 15:12, Georgi Valkov wrote:
quoted
Thank you, Greg!
git send-email drivers/net/0001-ipheth-fix-EOVERFLOW-in-ipheth_rcvbulk_callback.patch
...
Result: OK
I hope I got right. I added most of the e-mail addresses, and also tried adding Message-Id.
I have not received the e-mail yet, so I cannot confirm if it worked or not.
What happened here afterwards?
I just found out the hard way that this patch is still not in mainline
but really needed.
I have not seen the repost :(
Would it help if I do that on behalf of Georgi? Meanwhile, I can add a tested-by to it, after almost a full working day with it applied.
Yes, please do it! The faster it gets mainline, the more people will benefit from the fix. As far as I recall, some months ago someone asked me to submit the patch using git mail or something like that, which I did for the first time. It command reported success, but I did not get any replays since then from anyone. I intended to resubmit it the following week, but got overwhelmed by tasks, and the time passed. Meanwhile I still keep the patch in GitHub/httpstorm/openwrt, brach gvalkov. No changes are required since the original e-mail, so it can be submitted to mainline.
There is another issue with my iPhone 7 Plus, which is unrelated to this patch:
If an iPhone is tethered to a MacBook, the next time it gets connected to an OpenWRT router the USB Ethernet interface appears, but there is no communication. Hence I would assume this unrelated issue also has to be fixed in another patch. I can confirm that in this state macOS and Windows are able to use USB tethering, only OpenWRT is affected. So far I found the following workarounds:
* reboot the phone or run:
* usbreset 002/002 && /etc/init.d/usbmuxd restart
The same happens if the phone reboots due to extreme cold temperatures while tethered. Finally there is also a bug or possible hardware/baseband fault in my phone where every few days the modem reboots: the LTE icon disappears for a few seconds, and tethering is turned off. Either way, running the commands mentioned above re-enable tethering and restore the communication instantly. It would be nice if a watchdog is integrated in ipheth to trigger recovery automatically.
Georgi Valkov
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux