[PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
Subsystems:
networking [general], the rest, virtio and vhost vsock driver, virtio core, vm sockets (af_vsock)
STALE1859d
4 messages,
3 authors,
2021-07-20 · open the first message on its own page
From: Xianting Tian <redacted>
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <redacted>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
return 0;
--
2.17.1
Please help review this one, thanks
ignore the one https://lkml.org/lkml/2021/7/19/3279
<https://lkml.org/lkml/2021/7/19/3279>, which contains wrong mail address.
在 2021/7/20 上午11:42, Xianting Tian 写道:
quoted hunk
From: Xianting Tian <redacted>
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <redacted>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
return 0;
在 2021/7/20 上午11:42, Xianting Tian 写道:
quoted hunk
From: Xianting Tian <redacted>
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <redacted>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
It's better to do this after the mutex_lock().
Thanks
return 0;
thanks ,
I will sent V2 patch.
在 2021/7/20 下午2:28, Jason Wang 写道:
在 2021/7/20 上午11:42, Xianting Tian 写道:
quoted
From: Xianting Tian <redacted>
Add the missed virtio_device_ready() to set vsock frontend ready.
Signed-off-by: Xianting Tian <redacted>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vmw_vsock/virtio_transport.c
b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct
virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);
+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);
It's better to do this after the mutex_lock().
Thanks
quoted
return 0;