[PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

Subsystems: mediatek switch driver, networking drivers, networking [dsa], the rest

STALE1870d

3 messages, 3 authors, 2021-07-20 · open the first message on its own page

[PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

From: <hidden>
Date: 2021-07-19 19:02:44

From: Eric Woudstra <redacted>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
Signed-off-by: Eric Woudstra <redacted>
---
 drivers/net/dsa/mt7530.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 9e4df35f9..69f21b716 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -366,7 +366,8 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid,
 	int i;
 
 	reg[1] |= vid & CVID_MASK;
-	reg[1] |= ATA2_IVL;
+	if (vid > 1)
+		reg[1] |= ATA2_IVL;
 	reg[2] |= (aging & AGE_TIMER_MASK) << AGE_TIMER;
 	reg[2] |= (port_mask & PORT_MAP_MASK) << PORT_MAP;
 	/* STATIC_ENT indicate that entry is static wouldn't
-- 
2.25.1

Re: [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-07-19 19:34:58

On 7/19/21 11:23 AM, ericwouds@gmail.com wrote:
From: Eric Woudstra <redacted>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
Signed-off-by: Eric Woudstra <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-07-20 14:19:14

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 19 Jul 2021 20:23:57 +0200 you wrote:
From: Eric Woudstra <redacted>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
Signed-off-by: Eric Woudstra <redacted>

[...]
Here is the summary with links:
  - [net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1
    https://git.kernel.org/netdev/net/c/7e777021780e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help