[PATCH v1 1/1] ray_cs: use %*ph to print small buffer

Subsystems: networking drivers (wireless), the rest

STALE1863d LANDED

Landed in mainline as 502213fd8fca on 2021-08-21.

3 messages, 3 authors, 2021-08-21 · open the first message on its own page

[PATCH v1 1/1] ray_cs: use %*ph to print small buffer

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-07-12 14:29:24 

Use %*ph format to print small buffer as hex string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/wireless/ray_cs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 590bd974d94f..de614ac60421 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2424,9 +2424,7 @@ static void rx_authenticate(ray_dev_t *local, struct rcs __iomem *prcs,
 	copy_from_rx_buff(local, buff, pkt_addr, rx_len & 0xff);
 	/* if we are trying to get authenticated */
 	if (local->sparm.b4.a_network_type == ADHOC) {
-		pr_debug("ray_cs rx_auth var= %02x %02x %02x %02x %02x %02x\n",
-		      msg->var[0], msg->var[1], msg->var[2], msg->var[3],
-		      msg->var[4], msg->var[5]);
+		pr_debug("ray_cs rx_auth var= %6ph\n", msg->var);
 		if (msg->var[2] == 1) {
 			pr_debug("ray_cs Sending authentication response.\n");
 			if (!build_auth_frame
-- 
2.30.2

Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer

From: Kalle Valo <hidden>
Date: 2021-08-21 17:15:12 

Andy Shevchenko [off-list ref] wrote:

Use %*ph format to print small buffer as hex string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied to wireless-drivers-next.git, thanks.

502213fd8fca ray_cs: use %*ph to print small buffer

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210712142943.23981-1-andriy.shevchenko@linux.intel.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v1 1/1] ray_cs: use %*ph to print small buffer

From: Joe Perches <joe@perches.com>
Date: 2021-08-21 19:38:57 

On Sat, 2021-08-21 at 17:14 +0000, Kalle Valo wrote:
Andy Shevchenko [off-list ref] wrote:
quoted
Use %*ph format to print small buffer as hex string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied to wireless-drivers-next.git, thanks.

502213fd8fca ray_cs: use %*ph to print small buffer
There's one more of these in the same file but it's in an #ifdef 0 block...
---
 drivers/net/wireless/ray_cs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 590bd974d94f4..849216fbb8363 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2284,9 +2284,9 @@ static void untranslate(ray_dev_t *local, struct sk_buff *skb, int len)
 			       DUMP_PREFIX_NONE, 16, 1,
 			       skb->data, 64, true);
 		printk(KERN_DEBUG
-		       "type = %08x, xsap = %02x%02x%02x, org = %02x02x02x\n",
+		       "type = %08x, xsap = %02x%02x%02x, org = %3phN\n",
 		       ntohs(type), psnap->dsap, psnap->ssap, psnap->ctrl,
-		       psnap->org[0], psnap->org[1], psnap->org[2]);
+		       psnap->org);
 		printk(KERN_DEBUG "untranslate skb->data = %p\n", skb->data);
 	}
 #endif
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help