linux-next: Fixes tag needs some work in the net tree

4 messages, 3 authors, 2021-07-08 · open the first message on its own page

linux-next: Fixes tag needs some work in the net tree

From: Stephen Rothwell <hidden>
Date: 2021-07-08 21:31:14

Hi all,

In commit

  9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")

Fixes tag

  Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")

has these problem(s):

  - No SHA1 recognised

Not worth rebasing for, just more care next time.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the net tree

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-07-08 21:38:18

On 7/8/21 2:31 PM, Stephen Rothwell wrote:
Hi all,

In commit

  9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")

Fixes tag

  Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")

has these problem(s):

  - No SHA1 recognised

Not worth rebasing for, just more care next time.
It is there though:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984

and has the proper format AFAICT, what am I missing?
-- 
Florian

Re: linux-next: Fixes tag needs some work in the net tree

From: Eric Dumazet <hidden>
Date: 2021-07-08 21:45:03


On 7/8/21 11:38 PM, Florian Fainelli wrote:
On 7/8/21 2:31 PM, Stephen Rothwell wrote:
quoted
Hi all,

In commit

  9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")

Fixes tag

  Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")

has these problem(s):

  - No SHA1 recognised

Not worth rebasing for, just more care next time.
It is there though:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984

and has the proper format AFAICT, what am I missing?
This commit was the first commit, adding the bug.

Your commit changelog had :

    Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
    Signed-off-by: Florian Fainelli [off-list ref]
    Reviewed-by: Roi Dayan [off-list ref]
    Reviewed-by: Eric Dumazet [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]

See the extra Fixes: word ?

Re: linux-next: Fixes tag needs some work in the net tree

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-07-08 21:45:58

On 7/8/21 2:44 PM, Eric Dumazet wrote:

On 7/8/21 11:38 PM, Florian Fainelli wrote:
quoted
On 7/8/21 2:31 PM, Stephen Rothwell wrote:
quoted
Hi all,

In commit

  9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")

Fixes tag

  Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")

has these problem(s):

  - No SHA1 recognised

Not worth rebasing for, just more care next time.
It is there though:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984

and has the proper format AFAICT, what am I missing?
This commit was the first commit, adding the bug.

Your commit changelog had :

    Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
    Signed-off-by: Florian Fainelli [off-list ref]
    Reviewed-by: Roi Dayan [off-list ref]
    Reviewed-by: Eric Dumazet [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]

See the extra Fixes: word ?
Doh! yes, sorry about that.
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help