[PATCH] selftests/net: remove min gso test in packet_snd

Subsystems: kernel selftest framework, networking [general], the rest

STALE1863d REVIEWED: 3 (3M)

1 review trailer.

2 messages, 2 authors, 2021-08-02 · open the first message on its own page

[PATCH] selftests/net: remove min gso test in packet_snd

From: Dust Li <dust.li@linux.alibaba.com>
Date: 2021-07-30 03:50:23

This patch removed the 'raw gso min size - 1' test which
always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
  raw gso min size - 1 (expected to fail)
  tx: 1524
  rx: 1472
  OK

After commit 7c6d2ecbda83 ("net: be more gentle about silly
gso requests coming from user"), we relaxed the min gso_size
check in virtio_net_hdr_to_skb().
So when a packet which is smaller then the gso_size,
GSO for this packet will not be set, the packet will be
send/recv successfully.

Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
 tools/testing/selftests/net/psock_snd.sh | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/net/psock_snd.sh b/tools/testing/selftests/net/psock_snd.sh
index 170be65e0816..1cbfeb5052ec 100755
--- a/tools/testing/selftests/net/psock_snd.sh
+++ b/tools/testing/selftests/net/psock_snd.sh
@@ -86,9 +86,6 @@ echo "raw truncate hlen - 1 (expected to fail: EINVAL)"
 echo "raw gso min size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${mss_exceeds}"
 
-echo "raw gso min size - 1 (expected to fail)"
-(! ./in_netns.sh ./psock_snd -v -c -g -l "${mss}")
-
 echo "raw gso max size"
 ./in_netns.sh ./psock_snd -v -c -g -l "${max_mss}"
 
-- 
2.19.1.3.ge56e4f7

Re: [PATCH] selftests/net: remove min gso test in packet_snd

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-02 09:40:07

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 30 Jul 2021 11:41:55 +0800 you wrote:
This patch removed the 'raw gso min size - 1' test which
always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
  raw gso min size - 1 (expected to fail)
  tx: 1524
  rx: 1472
  OK

[...]
Here is the summary with links:
  - selftests/net: remove min gso test in packet_snd
    https://git.kernel.org/netdev/net-next/c/cfba3fb68960

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help