[PATCH net-next] net: phylink: add phy change pause mode debug

Subsystems: ethernet phy library, networking drivers, sff/sfp/sfp+ module support, the rest

STALE1862d

3 messages, 3 authors, 2021-07-20 · open the first message on its own page

[PATCH net-next] net: phylink: add phy change pause mode debug

From: Russell King (Oracle) <hidden>
Date: 2021-07-20 11:15:25

Augment the phy link debug prints with the pause state.

Signed-off-by: Russell King (Oracle) <redacted>
---
 drivers/net/phy/phylink.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index eb29ef53d971..728eab380fd3 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -942,10 +942,11 @@ static void phylink_phy_change(struct phy_device *phydev, bool up)
 
 	phylink_run_resolve(pl);
 
-	phylink_dbg(pl, "phy link %s %s/%s/%s\n", up ? "up" : "down",
+	phylink_dbg(pl, "phy link %s %s/%s/%s/%s\n", up ? "up" : "down",
 		    phy_modes(phydev->interface),
 		    phy_speed_to_str(phydev->speed),
-		    phy_duplex_to_str(phydev->duplex));
+		    phy_duplex_to_str(phydev->duplex),
+		    phylink_pause_to_str(pl->phy_state.pause));
 }
 
 static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
-- 
2.20.1

Re: [PATCH net-next] net: phylink: add phy change pause mode debug

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-07-20 13:56:04

On Tue, Jul 20, 2021 at 12:15:20PM +0100, Russell King (Oracle) wrote:
Augment the phy link debug prints with the pause state.

Signed-off-by: Russell King (Oracle) <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next] net: phylink: add phy change pause mode debug

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-07-20 14:41:10

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 20 Jul 2021 12:15:20 +0100 you wrote:
Augment the phy link debug prints with the pause state.

Signed-off-by: Russell King (Oracle) <redacted>
---
 drivers/net/phy/phylink.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Here is the summary with links:
  - [net-next] net: phylink: add phy change pause mode debug
    https://git.kernel.org/netdev/net-next/c/d34869b44a17

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help