The igb driver provides support for PEROUT and EXTTS pin functions that
allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
are using the PEROUT function to feed a PTP corrected 1pps signal into an
FPGA as cross system synchronized time source.
Support for the PEROUT and EXTTS SDP functions is currently limited to
i210/i211 based adapters. This patch series enables these functions also
for 82580/i354/i350 based ones. Because the time registers of these
adapters do not have the nice split in second rollovers as the i210 has,
the implementation is slightly more complex compared to the i210
implementation.
The PEROUT function has been successfully tested on an i350 based ethernet
adapter. Using the following user space code excerpt, the driver outputs a
PTP corrected 1pps signal on the SDP0 pin of an i350:
struct ptp_pin_desc desc;
memset(&desc, 0, sizeof(desc));
desc.index = 0;
desc.func = PTP_PF_PEROUT;
desc.chan = 0;
if (ioctl(fd, PTP_PIN_SETFUNC, &desc) == 0) {
struct timespec ts;
if (clock_gettime(clkid, &ts) == 0) {
struct ptp_perout_request rq;
memset(&rq, 0, sizeof(rq));
rq.index = 0;
rq.start.sec = ts.tv_sec + 1;
rq.start.nsec = 500000000;
rq.period.sec = 1;
rq.period.nsec = 0;
if (ioctl(fd, PTP_PEROUT_REQUEST, &rq) == 0) {
/* 1pps signal is now available on SDP0 */
}
}
}
The added EXTTS function has not been tested. However, looking at the data
sheets, the layout of the registers involved match the i210 exactly except
for the time registers mentioned before. Hence the almost identical
implementation.
Resend, putting maintainers on the CC.
Ruud Bos (4):
igb: move SDP config initialization to separate function
igb: move PEROUT and EXTTS isr logic to separate functions
igb: support PEROUT on 82580/i354/i350
igb: support EXTTS on 82580/i354/i350
drivers/net/ethernet/intel/igb/igb_main.c | 141 ++++++++++++-----
drivers/net/ethernet/intel/igb/igb_ptp.c | 183 ++++++++++++++++++++--
2 files changed, 279 insertions(+), 45 deletions(-)
--
2.30.2
UNRESTRICTED
HBK Benelux B.V., Schutweg 15a, NL-5145 NP Waalwijk, The Netherlands www.hbkworld.com Registered as B.V. (Dutch limited liability company) in the Dutch commercial register 08183075 0000 Company domiciled in Waalwijk Managing Directors : Alexandra Hellemans, Jens Wiegand, Jorn Bagijn The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-07-19 14:28:50
On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote:
The igb driver provides support for PEROUT and EXTTS pin functions that
allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
are using the PEROUT function to feed a PTP corrected 1pps signal into an
FPGA as cross system synchronized time source.
Please always Cc: The PTP maintainer for PTP patches.
Richard Cochran [off-list ref]
Andrew
From: Andrew Lunn <andrew@lunn.ch>
Sent: Monday, July 19, 2021 16:29
To: Ruud Bos <redacted>
Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org;
jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; Richard Cochran
[off-list ref]
Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS
PTP pin functions on 82580/i354/i350
On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote:
quoted
The igb driver provides support for PEROUT and EXTTS pin functions that
allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
are using the PEROUT function to feed a PTP corrected 1pps signal into an
FPGA as cross system synchronized time source.
Please always Cc: The PTP maintainer for PTP patches.
Richard Cochran [off-list ref]
Thanks, will do that!
Do I need to resend again?
This is my first ever contribution, so it's all kinda new to me, sorry :-)
Best regards, Ruud
UNRESTRICTED
HBK Benelux B.V., Schutweg 15a, NL-5145 NP Waalwijk, The Netherlands www.hbkworld.com Registered as B.V. (Dutch limited liability company) in the Dutch commercial register 08183075 0000 Company domiciled in Waalwijk Managing Directors : Alexandra Hellemans, Jens Wiegand, Jorn Bagijn The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-07-19 15:02:35
On Mon, Jul 19, 2021 at 02:45:06PM +0000, Ruud Bos wrote:
quoted
From: Andrew Lunn <andrew@lunn.ch>
Sent: Monday, July 19, 2021 16:29
To: Ruud Bos <redacted>
Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org;
jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; Richard Cochran
[off-list ref]
Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS
PTP pin functions on 82580/i354/i350
On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote:
quoted
The igb driver provides support for PEROUT and EXTTS pin functions that
allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
are using the PEROUT function to feed a PTP corrected 1pps signal into an
FPGA as cross system synchronized time source.
Please always Cc: The PTP maintainer for PTP patches.
Richard Cochran [off-list ref]
Thanks, will do that!
Do I need to resend again?
It is probably a good idea to resend. It will make it easier for
Richard if the patches are in his mailbox.
This is my first ever contribution, so it's all kinda new to me,
sorry :-)
Cc: Richard is not so obvious as it should be, since
./scripts/get_maintainers.pl would not of suggested it, since you are
not modify the PTP core. It takes a bit of experience to know this.
This is the second time something like this has happened recently for
Intel Ethernet drivers. The other case was making use of the LED
subsystem from within an Ethernet driver, and the LED subsystem
maintainers were not Cc:. It would be good if the Intel Maintainers
actually took notice of this, they have the experience to know better.
I noticed your patches are not threaded. Did you use git send-email?
It normally does thread a patchset. The threading keeps the patchset
together, which can be important for some of the bots which scoop up
patches in emails and run tests on them. Please see if you can fix
that in the resend.
Andrew