[PATCH net] net/tcp_fastopen: remove obsolete extern

Subsystems: networking [general], networking [tcp], the rest

STALE1861d LANDED

Landed in mainline as 749468760b95 on 2021-07-20.

3 messages, 3 authors, 2021-07-20 · open the first message on its own page

[PATCH net] net/tcp_fastopen: remove obsolete extern

From: Eric Dumazet <hidden>
Date: 2021-07-19 09:20:33

From: Eric Dumazet <edumazet@google.com>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
a global variable.

Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Haishuang Yan <redacted>
Cc: Wei Wang <redacted>
Cc: Yuchung Cheng <redacted>
Cc: Neal Cardwell <ncardwell@google.com>
---
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
 	struct rcu_head	rcu;
 };
 
-extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
 void tcp_fastopen_active_disable(struct sock *sk);
 bool tcp_fastopen_active_should_disable(struct sock *sk);
 void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
-- 
2.32.0.402.g57bb445576-goog

Re: [PATCH net] net/tcp_fastopen: remove obsolete extern

From: Wei Wang <hidden>
Date: 2021-07-19 16:10:42

On Mon, Jul 19, 2021 at 2:20 AM Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <edumazet@google.com>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
a global variable.

Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Haishuang Yan <redacted>
Cc: Wei Wang <redacted>
Cc: Yuchung Cheng <redacted>
Cc: Neal Cardwell <ncardwell@google.com>
---
Acked-by: Wei Wang <redacted>
quoted hunk
 include/net/tcp.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
        struct rcu_head rcu;
 };

-extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
 void tcp_fastopen_active_disable(struct sock *sk);
 bool tcp_fastopen_active_should_disable(struct sock *sk);
 void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
--
2.32.0.402.g57bb445576-goog

Re: [PATCH net] net/tcp_fastopen: remove obsolete extern

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-07-20 10:32:49

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 19 Jul 2021 02:20:28 -0700 you wrote:
From: Eric Dumazet <edumazet@google.com>

After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
a global variable.

Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Haishuang Yan <redacted>
Cc: Wei Wang <redacted>
Cc: Yuchung Cheng <redacted>
Cc: Neal Cardwell <ncardwell@google.com>

[...]
Here is the summary with links:
  - [net] net/tcp_fastopen: remove obsolete extern
    https://git.kernel.org/netdev/net/c/749468760b95

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help