[PATCH net] net: stmmac: Terminate FPE workqueue in suspend

From: Mohammad Athari Bin Ismail <redacted>

Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
during suspend. So, in suspend mode, there will be no FPE workqueue
available. Without this fix, new additional FPE workqueue will be created
in every suspend->resume cycle.

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <redacted>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index c87202cbd3d6..796ad594543d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

@@ -7170,6 +7170,7 @@ int stmmac_suspend(struct device *dev)
 				     priv->plat->rx_queues_to_use, false);
 
 		stmmac_fpe_handshake(priv, false);
+		stmmac_fpe_stop_wq(priv);
 	}
 
 	priv->speed = SPEED_UNKNOWN;

-- 
2.17.1

On Wed, Jun 30, 2021 at 05:17:54PM +0800, mohammad.athari.ismail@intel.com wrote:

From: Mohammad Athari Bin Ismail <redacted>

Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue
during suspend. So, in suspend mode, there will be no FPE workqueue
available. Without this fix, new additional FPE workqueue will be created
in every suspend->resume cycle.

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail <redacted>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: Wednesday, June 30, 2021 5:32 PM
To: Ismail, Mohammad Athari <redacted>
Cc: Alexandre Torgue <redacted>; Jose Abreu
[off-list ref]; David S . Miller [off-list ref]; Jakub
Kicinski [off-list ref]; Giuseppe Cavallaro [off-list ref];
Maxime Coquelin [off-list ref]; Ong, Boon Leong
[off-list ref]; Voon, Weifeng [off-list ref]; Tan,
Tee Min [off-list ref]; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; stable@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: Terminate FPE workqueue in suspend

On Wed, Jun 30, 2021 at 05:17:54PM +0800,
mohammad.athari.ismail@intel.com wrote:

quoted

From: Mohammad Athari Bin Ismail <redacted>

Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE
workqueue during suspend. So, in suspend mode, there will be no FPE
workqueue available. Without this fix, new additional FPE workqueue
will be created in every suspend->resume cycle.

Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner
hand-shaking procedure")
Signed-off-by: Mohammad Athari Bin Ismail
[off-list ref]
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel
tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

I'm sorry. Will follow the correct process. Thank you for the advice.

-Athari-