[PATCH v2] net/mlx5: Fix missing error code in mlx5_init_fs()

Subsystems: mellanox mlx5 core vpi driver, networking drivers, the rest

STALE1873d

2 messages, 2 authors, 2021-06-22 · open the first message on its own page

[PATCH v2] net/mlx5: Fix missing error code in mlx5_init_fs()

From: Jiapeng Chong <hidden>
Date: 2021-06-22 06:09:39

The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'err'.

Eliminate the follow smatch warning:

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
warn: missing error code 'err'.

Reported-by: Abaci Robot <redacted>
Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering").
Signed-off-by: Jiapeng Chong <redacted>
---
Changes in v2:
  - For the follow advice: https://lore.kernel.org/patchwork/patch/1446816/

 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 2cd7aea..b861745 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -2969,8 +2969,11 @@ int mlx5_init_fs(struct mlx5_core_dev *dev)
 		return err;
 
 	steering = kzalloc(sizeof(*steering), GFP_KERNEL);
-	if (!steering)
+	if (!steering) {
+		err = -ENOMEM;
 		goto err;
+	}
+
 	steering->dev = dev;
 	dev->priv.steering = steering;
 
-- 
1.8.3.1

Re: [PATCH v2] net/mlx5: Fix missing error code in mlx5_init_fs()

From: Saeed Mahameed <saeed@kernel.org>
Date: 2021-06-22 21:38:49

On Tue, 2021-06-22 at 14:09 +0800, Jiapeng Chong wrote:
The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'err'.

Eliminate the follow smatch warning:

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
warn: missing error code 'err'.

Reported-by: Abaci Robot <redacted>
Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all
firmware steering").
Signed-off-by: Jiapeng Chong <redacted>
---
Changes in v2:
  - For the follow advice:
https://lore.kernel.org/patchwork/patch/1446816/

Applied to net-next-mlx5
Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help