[PATCH] qlcnic: remove redundant continue statement

Subsystems: networking drivers, qlogic qlcnic (1/10)gb ethernet driver, the rest

STALE1885d

2 messages, 2 authors, 2021-06-18 · open the first message on its own page

[PATCH] qlcnic: remove redundant continue statement

From: Colin King <hidden>
Date: 2021-06-18 10:19:47

From: Colin Ian King <redacted>

The continue statement at the end of a for-loop has no effect,
it is redundant and can be removed.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 3d9028d6b942..a4fa507903ee 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -3342,9 +3342,6 @@ qlcnic_can_start_firmware(struct qlcnic_adapter *adapter)
 	do {
 		msleep(1000);
 		prev_state = QLC_SHARED_REG_RD32(adapter, QLCNIC_CRB_DEV_STATE);
-
-		if (prev_state == QLCNIC_DEV_QUISCENT)
-			continue;
 	} while ((prev_state != QLCNIC_DEV_READY) && --dev_init_timeo);
 
 	if (!dev_init_timeo) {
-- 
2.31.1

Re: [PATCH] qlcnic: remove redundant continue statement

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:20:12

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 18 Jun 2021 11:19:19 +0100 you wrote:
From: Colin Ian King <redacted>

The continue statement at the end of a for-loop has no effect,
it is redundant and can be removed.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>

[...]
Here is the summary with links:
  - qlcnic: remove redundant continue statement
    https://git.kernel.org/netdev/net-next/c/60ae9f883138

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help