[PATCH] ethernet: marvell/octeontx2: Simplify the return expression of npc_is_same

Subsystems: marvell octeontx2 rvu admin function driver, networking drivers, the rest

STALE1876d

2 messages, 2 authors, 2021-06-18 · open the first message on its own page

[PATCH] ethernet: marvell/octeontx2: Simplify the return expression of npc_is_same

From: <hidden>
Date: 2021-06-18 07:35:24

From: dingsenjie <redacted>

Simplify the return expression in the rvu_npc_fs.c

Signed-off-by: dingsenjie <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index 14832b6..1995df4 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -116,11 +116,8 @@ static bool npc_is_field_present(struct rvu *rvu, enum key_fields type, u8 intf)
 static bool npc_is_same(struct npc_key_field *input,
 			struct npc_key_field *field)
 {
-	int ret;
-
-	ret = memcmp(&input->layer_mdata, &field->layer_mdata,
-		     sizeof(struct npc_layer_mdata));
-	return ret == 0;
+	return memcmp(&input->layer_mdata, &field->layer_mdata,
+		     sizeof(struct npc_layer_mdata)) == 0;
 }
 
 static void npc_set_layer_mdata(struct npc_mcam *mcam, enum key_fields type,
-- 
1.9.1

Re: [PATCH] ethernet: marvell/octeontx2: Simplify the return expression of npc_is_same

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:20:26

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 18 Jun 2021 15:34:31 +0800 you wrote:
From: dingsenjie <redacted>

Simplify the return expression in the rvu_npc_fs.c

Signed-off-by: dingsenjie <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Here is the summary with links:
  - ethernet: marvell/octeontx2: Simplify the return expression of npc_is_same
    https://git.kernel.org/netdev/net-next/c/e44dc724826c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help