[PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()

Subsystems: networking drivers, qcom ipa driver, the rest

STALE1879d

3 messages, 3 authors, 2021-06-17 · open the first message on its own page

[PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()

From: Yang Yingliang <hidden>
Date: 2021-06-17 05:07:34

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. of_node_put() on it before exiting
this function.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ipa/ipa_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
index 2243e3e5b7ea..f82130db32f6 100644
--- a/drivers/net/ipa/ipa_main.c
+++ b/drivers/net/ipa/ipa_main.c
@@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev)
 	}
 
 	ret = of_address_to_resource(node, 0, &res);
+	of_node_put(node);
 	if (ret) {
 		dev_err(dev, "error %d getting \"memory-region\" resource\n",
 			ret);
-- 
2.25.1

Re: [PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()

From: Alex Elder <hidden>
Date: 2021-06-17 10:17:28

On 6/17/21 12:11 AM, Yang Yingliang wrote:
This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. of_node_put() on it before exiting
this function.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
Acked-by: Alex Elder <redacted>
quoted hunk
---
  drivers/net/ipa/ipa_main.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
index 2243e3e5b7ea..f82130db32f6 100644
--- a/drivers/net/ipa/ipa_main.c
+++ b/drivers/net/ipa/ipa_main.c
@@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev)
  	}
  
  	ret = of_address_to_resource(node, 0, &res);
+	of_node_put(node);
  	if (ret) {
  		dev_err(dev, "error %d getting \"memory-region\" resource\n",
  			ret);

Re: [PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-17 18:40:10

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 17 Jun 2021 13:11:19 +0800 you wrote:
This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. of_node_put() on it before exiting
this function.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>

[...]
Here is the summary with links:
  - [net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()
    https://git.kernel.org/netdev/net-next/c/b244163f2c45

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help