[PATCH] mlxsw: spectrum_router: remove redundant continue statement

Subsystems: mellanox ethernet switch drivers, networking drivers, the rest

STALE1909d

3 messages, 3 authors, 2021-06-16 · open the first message on its own page

[PATCH] mlxsw: spectrum_router: remove redundant continue statement

From: Colin King <hidden>
Date: 2021-06-16 13:03:08

From: Colin Ian King <redacted>

The continue statement at the end of a for-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index bc47ed766878..7e221ef01437 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -5407,7 +5407,6 @@ mlxsw_sp_rt6_nexthop(struct mlxsw_sp_nexthop_group *nh_grp,
 		    ipv6_addr_equal((const struct in6_addr *) &nh->gw_addr,
 				    &rt->fib6_nh->fib_nh_gw6))
 			return nh;
-		continue;
 	}
 
 	return NULL;
-- 
2.31.1

Re: [PATCH] mlxsw: spectrum_router: remove redundant continue statement

From: Ido Schimmel <hidden>
Date: 2021-06-16 14:45:39

On Wed, Jun 16, 2021 at 02:02:58PM +0100, Colin King wrote:
From: Colin Ian King <redacted>

The continue statement at the end of a for-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>
For net-next:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks

Re: [PATCH] mlxsw: spectrum_router: remove redundant continue statement

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-16 19:50:16

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 16 Jun 2021 14:02:58 +0100 you wrote:
From: Colin Ian King <redacted>

The continue statement at the end of a for-loop has no effect,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <redacted>

[...]
Here is the summary with links:
  - mlxsw: spectrum_router: remove redundant continue statement
    https://git.kernel.org/netdev/net-next/c/fb0a1dacf2be

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help