[PATCH net-next] net: chelsio: cxgb4: use eth_zero_addr() to assign zero address

Subsystems: cxgb4 ethernet driver (cxgb4), networking drivers, the rest

STALE1919d

2 messages, 2 authors, 2021-06-16 · open the first message on its own page

[PATCH net-next] net: chelsio: cxgb4: use eth_zero_addr() to assign zero address

From: Yang Yingliang <hidden>
Date: 2021-06-16 06:40:35

Using eth_zero_addr() to assign zero address insetad of
inefficient copy from an array.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index ae3ad99fbd06..9e3ea5f7be2e 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -7782,7 +7782,6 @@ int t4_free_encap_mac_filt(struct adapter *adap, unsigned int viid,
 			   int idx, bool sleep_ok)
 {
 	struct fw_vi_mac_exact *p;
-	u8 addr[] = {0, 0, 0, 0, 0, 0};
 	struct fw_vi_mac_cmd c;
 	int ret = 0;
 	u32 exact;
@@ -7799,7 +7798,7 @@ int t4_free_encap_mac_filt(struct adapter *adap, unsigned int viid,
 	p = c.u.exact;
 	p->valid_to_idx = cpu_to_be16(FW_VI_MAC_CMD_VALID_F |
 				      FW_VI_MAC_CMD_IDX_V(idx));
-	memcpy(p->macaddr, addr, sizeof(p->macaddr));
+	eth_zero_addr(p->macaddr);
 	ret = t4_wr_mbox_meat(adap, adap->mbox, &c, sizeof(c), &c, sleep_ok);
 	return ret;
 }
-- 
2.25.1

Re: [PATCH net-next] net: chelsio: cxgb4: use eth_zero_addr() to assign zero address

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-16 08:00:19

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 16 Jun 2021 14:43:18 +0800 you wrote:
Using eth_zero_addr() to assign zero address insetad of
inefficient copy from an array.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
  - [net-next] net: chelsio: cxgb4: use eth_zero_addr() to assign zero address
    https://git.kernel.org/netdev/net-next/c/c7654495916e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help