[PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage

Subsystems: bpf [general] (safe dynamic programs and tools), the rest, xdp (express data path)

STALE1880d LANDED

Landed in mainline as dfdda1a0f4aa on 2021-06-17.

2 messages, 2 authors, 2021-06-16 · open the first message on its own page

[PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage

From: Wang Hai <hidden>
Date: 2021-06-15 13:58:39

xdp_sample_pkts usage() is missing the introduction of the
"-S" option, this patch adds it.

Signed-off-by: Wang Hai <redacted>
---
 samples/bpf/xdp_sample_pkts_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
index 706475e004cb..495e09897bd3 100644
--- a/samples/bpf/xdp_sample_pkts_user.c
+++ b/samples/bpf/xdp_sample_pkts_user.c
@@ -103,7 +103,8 @@ static void usage(const char *prog)
 	fprintf(stderr,
 		"%s: %s [OPTS] <ifname|ifindex>\n\n"
 		"OPTS:\n"
-		"    -F    force loading prog\n",
+		"    -F    force loading prog\n"
+		"    -S    use skb-mode\n",
 		__func__, prog);
 }
 
-- 
2.17.1

Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage

From: Jesper Dangaard Brouer <hidden>
Date: 2021-06-16 10:56:07

On Tue, 15 Jun 2021 21:57:24 +0800
Wang Hai [off-list ref] wrote:
xdp_sample_pkts usage() is missing the introduction of the
"-S" option, this patch adds it.

Signed-off-by: Wang Hai <redacted>
---
 samples/bpf/xdp_sample_pkts_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")

Acked-by: Jesper Dangaard Brouer <redacted>
 
quoted hunk
diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
index 706475e004cb..495e09897bd3 100644
--- a/samples/bpf/xdp_sample_pkts_user.c
+++ b/samples/bpf/xdp_sample_pkts_user.c
@@ -103,7 +103,8 @@ static void usage(const char *prog)
 	fprintf(stderr,
 		"%s: %s [OPTS] <ifname|ifindex>\n\n"
 		"OPTS:\n"
-		"    -F    force loading prog\n",
+		"    -F    force loading prog\n"
+		"    -S    use skb-mode\n",
 		__func__, prog);
 }
 
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help