[PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage

Subsystems: bpf [general] (safe dynamic programs and tools), the rest, xdp (express data path)

STALE1881d LANDED

Landed in mainline as bf067f1c5123 on 2021-06-17.

2 messages, 2 authors, 2021-06-16 · open the first message on its own page

[PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage

From: Wang Hai <hidden>
Date: 2021-06-15 13:57:03

xdp_fwd usage() is missing the introduction of the "-S"
and "-F" options, this patch adds it.

Signed-off-by: Wang Hai <redacted>
---
 samples/bpf/xdp_fwd_user.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c
index 74a4583d0d86..00061261a8da 100644
--- a/samples/bpf/xdp_fwd_user.c
+++ b/samples/bpf/xdp_fwd_user.c
@@ -67,6 +67,8 @@ static void usage(const char *prog)
 		"usage: %s [OPTS] interface-list\n"
 		"\nOPTS:\n"
 		"    -d    detach program\n"
+		"    -S    use skb-mode\n"
+		"    -F    force loading prog\n"
 		"    -D    direct table lookups (skip fib rules)\n",
 		prog);
 }
-- 
2.17.1

Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_fwd usage

From: Jesper Dangaard Brouer <hidden>
Date: 2021-06-16 10:53:01

On Tue, 15 Jun 2021 21:55:54 +0800
Wang Hai [off-list ref] wrote:
xdp_fwd usage() is missing the introduction of the "-S"
and "-F" options, this patch adds it.

Signed-off-by: Wang Hai <redacted>
---
 samples/bpf/xdp_fwd_user.c | 2 ++
 1 file changed, 2 insertions(+)

Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")

LGTM but please add "Fixes:" tag next time, I think patchwork will pick
this up via this reply.

Acked-by: Jesper Dangaard Brouer <redacted>

quoted hunk
diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c
index 74a4583d0d86..00061261a8da 100644
--- a/samples/bpf/xdp_fwd_user.c
+++ b/samples/bpf/xdp_fwd_user.c
@@ -67,6 +67,8 @@ static void usage(const char *prog)
 		"usage: %s [OPTS] interface-list\n"
 		"\nOPTS:\n"
 		"    -d    detach program\n"
+		"    -S    use skb-mode\n"
+		"    -F    force loading prog\n"
 		"    -D    direct table lookups (skip fib rules)\n",
 		prog);
 }
    -


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help