[PATCH] ipv6: fib6: remove redundant initialization of variable err

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE1910d

2 messages, 2 authors, 2021-06-14 · open the first message on its own page

[PATCH] ipv6: fib6: remove redundant initialization of variable err

From: Colin King <hidden>
Date: 2021-06-13 13:46:44

From: Colin Ian King <redacted>

The variable err is being initialized with a value that is never read, the
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 net/ipv6/fib6_rules.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
index 8f9a83314de7..40f3e4f9f33a 100644
--- a/net/ipv6/fib6_rules.c
+++ b/net/ipv6/fib6_rules.c
@@ -467,7 +467,7 @@ static const struct fib_rules_ops __net_initconst fib6_rules_ops_template = {
 static int __net_init fib6_rules_net_init(struct net *net)
 {
 	struct fib_rules_ops *ops;
-	int err = -ENOMEM;
+	int err;
 
 	ops = fib_rules_register(&fib6_rules_ops_template, net);
 	if (IS_ERR(ops))
-- 
2.31.1

Re: [PATCH] ipv6: fib6: remove redundant initialization of variable err

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-14 19:50:38

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 13 Jun 2021 14:46:36 +0100 you wrote:
From: Colin Ian King <redacted>

The variable err is being initialized with a value that is never read, the
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>

[...]
Here is the summary with links:
  - ipv6: fib6: remove redundant initialization of variable err
    https://git.kernel.org/netdev/net-next/c/b5ec0705ffe8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help