[PATCH] igb: Fix an error handling path in 'igb_probe()'

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE1869d

2 messages, 2 authors, 2021-06-25 · open the first message on its own page

[PATCH] igb: Fix an error handling path in 'igb_probe()'

From: Christophe JAILLET <hidden>
Date: 2021-06-12 20:08:43

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting")
Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 5db303d64d14..cf1de2b9ab71 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3615,6 +3615,7 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_ioremap:
 	free_netdev(netdev);
 err_alloc_etherdev:
+	pci_disable_pcie_error_reporting(pdev);
 	pci_release_mem_regions(pdev);
 err_pci_reg:
 err_dma:
-- 
2.30.2

RE: [Intel-wired-lan] [PATCH] igb: Fix an error handling path in 'igb_probe()'

From: Brelinski, TonyX <hidden>
Date: 2021-06-25 22:39:59

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Christophe JAILLET
Sent: Saturday, June 12, 2021 1:09 PM
To: Brandeburg, Jesse <redacted>; Nguyen, Anthony L
[off-list ref]; davem@davemloft.net; kuba@kernel.org;
jeffrey.t.kirsher@intel.com; alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
JAILLET [off-list ref]; intel-wired-lan@lists.osuosl.org;
linux-kernel@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] igb: Fix an error handling path in
'igb_probe()'

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be
undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting")
Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 1 +
 1 file changed, 1 insertion(+)
Tested-by: Tony Brelinski <redacted> (A Contingent Worker at Intel)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help