[PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()'

Subsystems: networking drivers, netxen (1/10) gbe support, the rest

STALE1882d

2 messages, 2 authors, 2021-06-14 · open the first message on its own page

[PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()'

From: Christophe JAILLET <hidden>
Date: 2021-06-12 12:53:19

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: e87ad5539343 ("netxen: support pci error handlers")
Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 7e6bac85495d..344ea1143454 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -1602,6 +1602,8 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	free_netdev(netdev);
 
 err_out_free_res:
+	if (NX_IS_REVISION_P3(pdev->revision))
+		pci_disable_pcie_error_reporting(pdev);
 	pci_release_regions(pdev);
 
 err_out_disable_pdev:
-- 
2.30.2

Re: [PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()'

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-14 19:20:14

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 12 Jun 2021 14:53:12 +0200 you wrote:
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: e87ad5539343 ("netxen: support pci error handlers")
Signed-off-by: Christophe JAILLET <redacted>

[...]
Here is the summary with links:
  - netxen_nic: Fix an error handling path in 'netxen_nic_probe()'
    https://git.kernel.org/netdev/net/c/49a10c7b1762

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help