[PATCH net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c

Subsystems: ibm power sriov virtual nic device driver, linux for powerpc (32-bit and 64-bit), networking drivers, the rest

STALE1911d

4 messages, 4 authors, 2021-06-10 · open the first message on its own page

[PATCH net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c

From: Wang Hai <hidden>
Date: 2021-06-10 12:55:16

Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 5788bb956d73..77ab381a67a3 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2402,8 +2402,7 @@ static int ibmvnic_reset(struct ibmvnic_adapter *adapter,
 		goto err;
 	}
 
-	list_for_each(entry, &adapter->rwi_list) {
-		tmp = list_entry(entry, struct ibmvnic_rwi, list);
+	list_for_each_entry(tmp, &adapter->rwi_list, list) {
 		if (tmp->reset_reason == reason) {
 			netdev_dbg(netdev, "Skipping matching reset, reason=%s\n",
 				   reset_reason_to_string(reason));
-- 
2.17.1

Re: [PATCH net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c

From: Lijun Pan <hidden>
Date: 2021-06-10 14:52:37

On Thu, Jun 10, 2021 at 7:56 AM Wang Hai [off-list ref] wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
Acked-by: Lijun Pan <redacted>

Re: [PATCH net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c

From: Dany Madden <hidden>
Date: 2021-06-10 16:49:30

On 2021-06-10 07:52, Lijun Pan wrote:
On Thu, Jun 10, 2021 at 7:56 AM Wang Hai [off-list ref] wrote:
quoted
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
Acked-by: Lijun Pan <redacted>
Reviewed-by: Dany Madden <redacted>

Re: [PATCH net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-10 21:10:15

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 10 Jun 2021 20:54:17 +0800 you wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
  - [net-next] ibmvnic: Use list_for_each_entry() to simplify code in ibmvnic.c
    https://git.kernel.org/netdev/net-next/c/3e98ae0014cb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help