DORMANTno replies

[PATCH -next] netfilter: Make NETFILTER_NETLINK_HOOK depends on NF_TABLES

From: He Ying <hidden>
Date: 2021-06-09 09:56:49
Also in: lkml, netfilter-devel
Subsystem: netfilter, networking [general], the rest · Maintainers: Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Compiling errors happen when CONFIG_NETFILTER_NETLINK_HOOK = y
while CONFIG_NF_TABLES is not set:

net/netfilter/nfnetlink_hook.c: In function ‘nfnl_hook_put_nft_chain_info’:
net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function
‘nft_is_active’ [-Werror=implicit-function-declaration]
   76 |  if (!nft_is_active(net, chain))
      |       ^~~~~~~~~~~~~

Notice that nft_is_active macro is only defined when CONFIG_NF_TABLES
is enabled, so add dependency on NF_TABLES in NETFILTER_NETLINK_HOOK
configurations.

Fixes: e2cf17d3774c ("netfilter: add new hook nfnl subsystem")
Reported-by: Hulk Robot <redacted>
Signed-off-by: He Ying <redacted>
---
 net/netfilter/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index c81321372198..54395266339d 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -22,6 +22,7 @@ config NETFILTER_FAMILY_ARP
 config NETFILTER_NETLINK_HOOK
 	tristate "Netfilter base hook dump support"
 	depends on NETFILTER_ADVANCED
+	depends on NF_TABLES
 	select NETFILTER_NETLINK
 	help
 	  If this option is enabled, the kernel will include support
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help