[PATCH] nl80211: fix a mistake in grammar

Subsystems: 802.11 (including cfg80211/nl80211), the rest

STALE1890d

3 messages, 3 authors, 2021-06-09 · open the first message on its own page

[PATCH] nl80211: fix a mistake in grammar

From: <hidden>
Date: 2021-06-09 08:16:19

From: gushengxian <redacted>

Fix a mistake in grammar.

Signed-off-by: gushengxian <redacted>
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index fc9286afe3c9..68dff0ca3190 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -8128,7 +8128,7 @@ int nl80211_parse_random_mac(struct nlattr **attrs,
 	memcpy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC]), ETH_ALEN);
 	memcpy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK]), ETH_ALEN);
 
-	/* don't allow or configure an mcast address */
+	/* don't allow or configure a mcast address */
 	if (!is_multicast_ether_addr(mac_addr_mask) ||
 	    is_multicast_ether_addr(mac_addr))
 		return -EINVAL;
-- 
2.25.1

Re: [PATCH] nl80211: fix a mistake in grammar

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-06-09 08:55:52

On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
-	/* don't allow or configure an mcast address */
+	/* don't allow or configure a mcast address */
Arguable? I'd say "an M-cast" address, and I guess that's why it's
written that way. Not sure how else you'd say it, unless you always
expand it to "multicast" when reading.

johannes

Re: [PATCH] nl80211: fix a mistake in grammar

From: Randy Dunlap <hidden>
Date: 2021-06-09 15:01:18

On 6/9/21 1:55 AM, Johannes Berg wrote:
On Wed, 2021-06-09 at 01:15 -0700, 13145886936@163.com wrote:
quoted
-	/* don't allow or configure an mcast address */
+	/* don't allow or configure a mcast address */
Arguable? I'd say "an M-cast" address, and I guess that's why it's
written that way. Not sure how else you'd say it, unless you always
expand it to "multicast" when reading.
Agreed, it's ok as is.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help