The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/nvme/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
From: Christoph Hellwig <hch@lst.de> Date: 2021-06-08 12:19:32
On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Err, where did this appear from? This code has not been accepted into
the NVMe tree and is indeed not acceptable in this form.
Hi Christoph,
On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig [off-list ref] wrote:
On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
quoted
The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Err, where did this appear from? This code has not been accepted into
the NVMe tree and is indeed not acceptable in this form.
It was applied to net-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Christoph Hellwig <hch@lst.de> Date: 2021-06-08 13:43:10
Hi Dave,
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
From: David Miller <davem@davemloft.net> Date: 2021-06-08 19:21:08
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 8 Jun 2021 15:43:03 +0200
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
Please send me a revert, and I will apply it, thank you.
It's tricky because at least one driver uses the new interfaces.
Thank you.
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 8 Jun 2021 12:56:09 +0200 you wrote:
The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
[...]
From: Keith Busch <kbusch@kernel.org> Date: 2021-06-08 19:41:14
On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 8 Jun 2021 15:43:03 +0200
quoted
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
Please send me a revert, and I will apply it, thank you.
It's tricky because at least one driver uses the new interfaces.
Shouldn't whoever merged un-ACK'ed patches from a different subsystem
get to own the tricky revert?