[PATCH net-next] net: lapb: Use list_for_each_entry() to simplify code in lapb_iface.c

Subsystems: networking [general], the rest, x.25 stack

STALE1891d

2 messages, 2 authors, 2021-06-08 · open the first message on its own page

[PATCH net-next] net: lapb: Use list_for_each_entry() to simplify code in lapb_iface.c

From: Wang Hai <hidden>
Date: 2021-06-08 08:03:02

Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 net/lapb/lapb_iface.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
index 1078e14f1acf..0971ca48ba15 100644
--- a/net/lapb/lapb_iface.c
+++ b/net/lapb/lapb_iface.c
@@ -80,11 +80,9 @@ static void __lapb_insert_cb(struct lapb_cb *lapb)
 
 static struct lapb_cb *__lapb_devtostruct(struct net_device *dev)
 {
-	struct list_head *entry;
 	struct lapb_cb *lapb, *use = NULL;
 
-	list_for_each(entry, &lapb_list) {
-		lapb = list_entry(entry, struct lapb_cb, node);
+	list_for_each_entry(lapb, &lapb_list, node) {
 		if (lapb->dev == dev) {
 			use = lapb;
 			break;
-- 
2.17.1

Re: [PATCH net-next] net: lapb: Use list_for_each_entry() to simplify code in lapb_iface.c

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-08 23:40:18

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 8 Jun 2021 08:13:01 +0000 you wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 net/lapb/lapb_iface.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Here is the summary with links:
  - [net-next] net: lapb: Use list_for_each_entry() to simplify code in lapb_iface.c
    https://git.kernel.org/netdev/net-next/c/e83332842a46

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help