[PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c

Subsystems: networking [general], the rest, x.25 stack

STALE1887d

2 messages, 2 authors, 2021-06-08 · open the first message on its own page

[PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c

From: Wang Hai <hidden>
Date: 2021-06-08 07:55:08

Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 net/x25/x25_link.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index 57a81100c5da..5460b9146dd8 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -332,12 +332,9 @@ void x25_link_device_down(struct net_device *dev)
 struct x25_neigh *x25_get_neigh(struct net_device *dev)
 {
 	struct x25_neigh *nb, *use = NULL;
-	struct list_head *entry;
 
 	read_lock_bh(&x25_neigh_list_lock);
-	list_for_each(entry, &x25_neigh_list) {
-		nb = list_entry(entry, struct x25_neigh, node);
-
+	list_for_each_entry(nb, &x25_neigh_list, node) {
 		if (nb->dev == dev) {
 			use = nb;
 			break;
-- 
2.17.1

Re: [PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-08 23:40:24

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 8 Jun 2021 08:05:05 +0000 you wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 net/x25/x25_link.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Here is the summary with links:
  - [net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c
    https://git.kernel.org/netdev/net-next/c/3835a6614ae7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help