[PATCH net-next] net: qede: Use list_for_each_entry() to simplify code

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE1888d

2 messages, 2 authors, 2021-06-08 · open the first message on its own page

[PATCH net-next] net: qede: Use list_for_each_entry() to simplify code

From: Wang Hai <hidden>
Date: 2021-06-08 07:47:38

Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/ethernet/qlogic/qede/qede_rdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_rdma.c b/drivers/net/ethernet/qlogic/qede/qede_rdma.c
index 2f6598086d9b..6304514a6f2c 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_rdma.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_rdma.c
@@ -247,12 +247,10 @@ static struct qede_rdma_event_work *
 qede_rdma_get_free_event_node(struct qede_dev *edev)
 {
 	struct qede_rdma_event_work *event_node = NULL;
-	struct list_head *list_node = NULL;
 	bool found = false;
 
-	list_for_each(list_node, &edev->rdma_info.rdma_event_list) {
-		event_node = list_entry(list_node, struct qede_rdma_event_work,
-					list);
+	list_for_each_entry(event_node, &edev->rdma_info.rdma_event_list,
+			    list) {
 		if (!work_pending(&event_node->work)) {
 			found = true;
 			break;
-- 
2.17.1

Re: [PATCH net-next] net: qede: Use list_for_each_entry() to simplify code

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-08 23:40:21

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 8 Jun 2021 07:57:37 +0000 you wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Hai <redacted>
---
 drivers/net/ethernet/qlogic/qede/qede_rdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Here is the summary with links:
  - [net-next] net: qede: Use list_for_each_entry() to simplify code
    https://git.kernel.org/netdev/net-next/c/36861d1f0408

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help