[PATCH net-next] net: micrel: check return value after calling platform_get_resource()

Subsystems: networking drivers, the rest

STALE1920d

2 messages, 2 authors, 2021-06-07 · open the first message on its own page

[PATCH net-next] net: micrel: check return value after calling platform_get_resource()

From: Yang Yingliang <hidden>
Date: 2021-06-07 14:51:24

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/micrel/ks8842.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
index caa251d0e381..b27713906d3a 100644
--- a/drivers/net/ethernet/micrel/ks8842.c
+++ b/drivers/net/ethernet/micrel/ks8842.c
@@ -1135,6 +1135,10 @@ static int ks8842_probe(struct platform_device *pdev)
 	unsigned i;
 
 	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!iomem) {
+		dev_err(&pdev->dev, "Invalid resource\n");
+		return -EINVAL;
+	}
 	if (!request_mem_region(iomem->start, resource_size(iomem), DRV_NAME))
 		goto err_mem_region;
 
-- 
2.25.1

Re: [PATCH net-next] net: micrel: check return value after calling platform_get_resource()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-07 21:10:21

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 7 Jun 2021 22:55:21 +0800 you wrote:
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/micrel/ks8842.c | 4 ++++
 1 file changed, 4 insertions(+)
Here is the summary with links:
  - [net-next] net: micrel: check return value after calling platform_get_resource()
    https://git.kernel.org/netdev/net-next/c/20f1932e2282

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help