[PATCH] sch_htb: fix doc warning in htb_add_to_id_tree()

Subsystems: networking [general], tc subsystem, the rest

STALE1918d

2 messages, 2 authors, 2021-06-03 · open the first message on its own page

[PATCH] sch_htb: fix doc warning in htb_add_to_id_tree()

From: Yu Kuai <hidden>
Date: 2021-06-03 13:58:38

Add description for parameters of htb_add_to_id_tree() to fix
gcc W=1 warnings:
net/sched/sch_htb.c:282: warning: Function parameter or member 'root' not described in 'htb_add_to_id_tree'
net/sched/sch_htb.c:282: warning: Function parameter or member 'cl' not described in 'htb_add_to_id_tree'
net/sched/sch_htb.c:282: warning: Function parameter or member 'prio' not described in 'htb_add_to_id_tree'

Signed-off-by: Yu Kuai <redacted>
---
 net/sched/sch_htb.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 282614614905..4f9304567dcc 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -273,6 +273,9 @@ static struct htb_class *htb_classify(struct sk_buff *skb, struct Qdisc *sch,
 
 /**
  * htb_add_to_id_tree - adds class to the round robin list
+ * @root: the root of the tree
+ * @cl: the class to add
+ * @prio: the give prio in class
  *
  * Routine adds class to the list (actually tree) sorted by classid.
  * Make sure that class is not already on such list for given prio.
-- 
2.31.1

Re: [PATCH] sch_htb: fix doc warning in htb_add_to_id_tree()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-03 22:30:15

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 3 Jun 2021 22:07:49 +0800 you wrote:
Add description for parameters of htb_add_to_id_tree() to fix
gcc W=1 warnings:
net/sched/sch_htb.c:282: warning: Function parameter or member 'root' not described in 'htb_add_to_id_tree'
net/sched/sch_htb.c:282: warning: Function parameter or member 'cl' not described in 'htb_add_to_id_tree'
net/sched/sch_htb.c:282: warning: Function parameter or member 'prio' not described in 'htb_add_to_id_tree'

Signed-off-by: Yu Kuai <redacted>

[...]
Here is the summary with links:
  - sch_htb: fix doc warning in htb_add_to_id_tree()
    https://git.kernel.org/netdev/net-next/c/a10541f5d9fa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help