[PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()

Subsystems: networking [general], the rest

STALE1894d

2 messages, 2 authors, 2021-06-03 · open the first message on its own page

[PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()

From: Jiapeng Chong <hidden>
Date: 2021-06-02 10:15:28

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>
---
 net/core/rtnetlink.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 714d5fa..3e84279 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4842,8 +4842,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
 	if (err < 0)
 		goto errout;
 
-	if (!skb->len)
+	if (!skb->len) {
+		err = -EINVAL;
 		goto errout;
+	}
 
 	rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
 	return 0;
-- 
1.8.3.1

Re: [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-03 21:00:10

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed,  2 Jun 2021 18:15:04 +0800 you wrote:
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

[...]
Here is the summary with links:
  - rtnetlink: Fix missing error code in rtnl_bridge_notify()
    https://git.kernel.org/netdev/net/c/a8db57c1d285

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help