[PATCH net-next] hamradio: bpqether: Fix -Wunused-const-variable warning

Subsystems: networking drivers, the rest

STALE1894d

2 messages, 2 authors, 2021-06-02 · open the first message on its own page

[PATCH net-next] hamradio: bpqether: Fix -Wunused-const-variable warning

From: YueHaibing <hidden>
Date: 2021-06-01 14:01:48

If CONFIG_PROC_FS is n, gcc warns:

drivers/net/hamradio/bpqether.c:437:36:
 warning: ‘bpq_seqops’ defined but not used [-Wunused-const-variable=]
 static const struct seq_operations bpq_seqops = {
                                    ^~~~~~~~~~
Use #ifdef macro to gurad this.

Signed-off-by: YueHaibing <redacted>
---
 drivers/net/hamradio/bpqether.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index 1ad6085994b1..0e623c2e8b2d 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -368,7 +368,7 @@ static int bpq_close(struct net_device *dev)
 
 /* ------------------------------------------------------------------------ */
 
-
+#ifdef CONFIG_PROC_FS
 /*
  *	Proc filesystem
  */
@@ -440,7 +440,7 @@ static const struct seq_operations bpq_seqops = {
 	.stop = bpq_seq_stop,
 	.show = bpq_seq_show,
 };
-
+#endif
 /* ------------------------------------------------------------------------ */
 
 static const struct net_device_ops bpq_netdev_ops = {
-- 
2.17.1

Re: [PATCH net-next] hamradio: bpqether: Fix -Wunused-const-variable warning

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-02 00:10:43

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 1 Jun 2021 22:00:52 +0800 you wrote:
If CONFIG_PROC_FS is n, gcc warns:

drivers/net/hamradio/bpqether.c:437:36:
 warning: ‘bpq_seqops’ defined but not used [-Wunused-const-variable=]
 static const struct seq_operations bpq_seqops = {
                                    ^~~~~~~~~~
Use #ifdef macro to gurad this.

[...]
Here is the summary with links:
  - [net-next] hamradio: bpqether: Fix -Wunused-const-variable warning
    https://git.kernel.org/netdev/net-next/c/e516f5be5b17

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help