# Re: \[PATCH net-next v4 2/3\] virtio\_net: add optional flow dissection in virtio\_net\_hdr\_to\_skb

- From: Willem de Bruijn \<willemdebruijn.kernel@gmail.com\>
- Date: 2021-06-21 13:19:22 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/06/11205920
- Thread: https://ratatoskr.run/netdev/2021/06/11204926/t.md

```text
> >> 2) use some general fields instead of virtio-net specific fields, e.g
> >> using device header instead of vnet header in the flow keys strcuture
> > Can you give an example of what would be in the device header?
> >
> > Specific for GSO, we have two sets of constants: VIRTIO_NET_HDR_GSO_..
> > and SKB_GSO_.. Is the suggestion to replace the current use of the
> > first in field flow_keys->virtio_net_hdr.gso_type with the second in
> > flow_keys->gso_type?
>
>
> No, I meant using a general fields like flow_keys->device_hdr. And use
> bpf helpers to access the field.

What would be in this device_hdr field, and what would the bpf helpers
access? I don't fully follow what this is if not vnet_hdr.
```
