[PATCH net-next] net: iosm: remove an unnecessary NULL check

Subsystems: intel wwan iosm driver, networking drivers, the rest, wwan drivers

STALE1874d

3 messages, 3 authors, 2021-06-21 · open the first message on its own page

[PATCH net-next] net: iosm: remove an unnecessary NULL check

From: Dan Carpenter <hidden>
Date: 2021-06-19 13:51:41

The address of &ipc_mux->ul_adb can't be NULL because it points to the
middle of a non-NULL struct.

Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
index fbf3cab3394c..e634ffc6ec08 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
@@ -477,7 +477,7 @@ static void ipc_mux_ul_adgh_finish(struct iosm_mux *ipc_mux)
 	long long bytes;
 	char *str;
 
-	if (!ul_adb || !ul_adb->dest_skb) {
+	if (!ul_adb->dest_skb) {
 		dev_err(ipc_mux->dev, "no dest skb");
 		return;
 	}
-- 
2.30.2

RE: [PATCH net-next] net: iosm: remove an unnecessary NULL check

From: Kumar, M Chetan <hidden>
Date: 2021-06-20 15:50:34

The address of &ipc_mux->ul_adb can't be NULL because it points to the
middle of a non-NULL struct.

Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by: M Chetan Kumar <redacted>

Re: [PATCH net-next] net: iosm: remove an unnecessary NULL check

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-21 19:20:19

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 19 Jun 2021 16:51:26 +0300 you wrote:
The address of &ipc_mux->ul_adb can't be NULL because it points to the
middle of a non-NULL struct.

Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
  - [net-next] net: iosm: remove an unnecessary NULL check
    https://git.kernel.org/netdev/net-next/c/d5fff4629bea

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help