[PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

Subsystems: networking [general], the rest

STALE1879d

3 messages, 3 authors, 2021-06-18 · open the first message on its own page

[PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-06-18 04:58:16

Currently UDP tunnel devices on top of VLANs lose the ability
to offload UDP GSO. Widen the pass thru features from TSO
to all GSO_SOFTWARE.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/8021q/vlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/8021q/vlan.h b/net/8021q/vlan.h
index fa3ad3d4d58c..edb6acde6b6f 100644
--- a/net/8021q/vlan.h
+++ b/net/8021q/vlan.h
@@ -108,7 +108,8 @@ static inline netdev_features_t vlan_tnl_features(struct net_device *real_dev)
 	netdev_features_t ret;
 
 	ret = real_dev->hw_enc_features &
-	      (NETIF_F_CSUM_MASK | NETIF_F_ALL_TSO | NETIF_F_GSO_ENCAP_ALL);
+	      (NETIF_F_CSUM_MASK | NETIF_F_GSO_SOFTWARE |
+	       NETIF_F_GSO_ENCAP_ALL);
 
 	if ((ret & NETIF_F_GSO_ENCAP_ALL) && (ret & NETIF_F_CSUM_MASK))
 		return (ret & ~NETIF_F_CSUM_MASK) | NETIF_F_HW_CSUM;
-- 
2.31.1

Re: [PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-06-18 19:05:07

On Fri, Jun 18, 2021 at 12:56 AM Jakub Kicinski [off-list ref] wrote:
Currently UDP tunnel devices on top of VLANs lose the ability
to offload UDP GSO. Widen the pass thru features from TSO
to all GSO_SOFTWARE.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:10:11

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 17 Jun 2021 21:55:56 -0700 you wrote:
Currently UDP tunnel devices on top of VLANs lose the ability
to offload UDP GSO. Widen the pass thru features from TSO
to all GSO_SOFTWARE.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/8021q/vlan.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
  - [net-next] net: vlan: pass thru all GSO_SOFTWARE in hw_enc_features
    https://git.kernel.org/netdev/net-next/c/9d72b8da9f13

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help