[PATCH] net: iosm: remove the repeated declaration and comment

Subsystems: intel wwan iosm driver, networking drivers, the rest, wwan drivers

STALE1928d

2 messages, 2 authors, 2021-06-16 · open the first message on its own page

[PATCH] net: iosm: remove the repeated declaration and comment

From: Shaokun Zhang <hidden>
Date: 2021-06-16 07:26:08

Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
repeated declaration and wrong comments.

Cc: M Chetan Kumar <redacted>
Cc: Intel Corporation <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Shaokun Zhang <redacted>
---
 drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
 1 file changed, 10 deletions(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
index bcf77aea06e7..45e6923da78f 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
+++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
@@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct iosm_mmio *ipc_mmio,
 				   phys_addr_t addr);
 
 /**
- * ipc_mmio_get_cp_version - Write context info and AP memory range addresses.
- *			     This needs to be called when CP is in
- *			     IPC_MEM_DEVICE_IPC_INIT state
- * @ipc_mmio:	Pointer to mmio instance
- *
- * Returns: cp version else failure value on error
- */
-int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
-
-/**
  * ipc_mmio_get_cp_version - Get the CP IPC version
  * @ipc_mmio:	Pointer to mmio instance
  *
-- 
2.7.4

RE: [PATCH] net: iosm: remove the repeated declaration and comment

From: Kumar, M Chetan <hidden>
Date: 2021-06-16 07:51:34

quoted hunk
Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
repeated declaration and wrong comments.

Cc: M Chetan Kumar <redacted>
Cc: Intel Corporation <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Shaokun Zhang <redacted>
---
 drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
 1 file changed, 10 deletions(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
index bcf77aea06e7..45e6923da78f 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
+++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
@@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct
iosm_mmio *ipc_mmio,
 				   phys_addr_t addr);

 /**
- * ipc_mmio_get_cp_version - Write context info and AP memory range
addresses.
- *			     This needs to be called when CP is in
- *			     IPC_MEM_DEVICE_IPC_INIT state
- * @ipc_mmio:	Pointer to mmio instance
- *
- * Returns: cp version else failure value on error
- */
-int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
-
-/**
  * ipc_mmio_get_cp_version - Get the CP IPC version
  * @ipc_mmio:	Pointer to mmio instance
  *
--
2.7.4
Thanks,
Reviewed-by: M Chetan Kumar <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help