[PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static

Subsystems: networking drivers, the rest

STALE1879d

2 messages, 2 authors, 2021-06-16 · open the first message on its own page

[PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static

From: Wei Yongjun <hidden>
Date: 2021-06-15 17:11:43

The sparse tool complains as follows:

drivers/net/mhi/net.c:385:23: warning:
 symbol 'mhi_wwan_ops' was not declared. Should it be static?

This symbol is not used outside of net.c, so marks it static.

Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/mhi/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 78d4a06fbeca..e5ec0d7510c8 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -382,7 +382,7 @@ static void mhi_net_dellink(void *ctxt, struct net_device *ndev,
 	dev_set_drvdata(&mhi_dev->dev, NULL);
 }
 
-const struct wwan_ops mhi_wwan_ops = {
+static const struct wwan_ops mhi_wwan_ops = {
 	.owner = THIS_MODULE,
 	.priv_size = sizeof(struct mhi_net_dev),
 	.setup = mhi_net_setup,

Re: [PATCH net-next] net: mhi: Make symbol 'mhi_wwan_ops' static

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-16 07:40:14

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 15 Jun 2021 17:21:59 +0000 you wrote:
The sparse tool complains as follows:

drivers/net/mhi/net.c:385:23: warning:
 symbol 'mhi_wwan_ops' was not declared. Should it be static?

This symbol is not used outside of net.c, so marks it static.

[...]
Here is the summary with links:
  - [net-next] net: mhi: Make symbol 'mhi_wwan_ops' static
    https://git.kernel.org/netdev/net-next/c/1d0bbbf22b74

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help