Hi Richard,

-----Original Message-----
From: Richard Cochran <richardcochran@gmail.com>
Sent: 2021年5月31日 21:49
To: Y.b. Lu <yangbo.lu@nxp.com>
Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; Claudiu
Manoil [off-list ref]; Jakub Kicinski [off-list ref]
Subject: Re: [net-next, v2, 7/7] enetc: support PTP domain timestamp
conversion

On Mon, May 31, 2021 at 11:26:18AM +0000, Y.b. Lu wrote:

quoted

So, the timestamp conversion could be in skbuff.c.
That's good to do this. But there are quite a lot of drivers using

timestamping.

quoted

Should we convert all drivers to use the helper, or let others do this when

they need?

I think we should convert them all.  Yes, it is work, but I will help.
I really like the vclock idea, especially because it will work with every clock.
Also, adding the helper will be a nice refactoring all by itself.

It seems socket.c __sock_recv_timestamp may be the better place.
HW timestamps are handled in it before going to user space.
I sent out a v3 patch for your reviewing. Maybe we don’t have to convert all drivers to a helper.
Thank you very much.

Thanks,
Richard