[PATCH net] net: mhi_net: Update the transmit handler prototype

Subsystems: networking drivers, the rest

STALE1885d

2 messages, 2 authors, 2021-06-14 · open the first message on its own page

[PATCH net] net: mhi_net: Update the transmit handler prototype

From: Subash Abhinov Kasiviswanathan <hidden>
Date: 2021-06-14 21:04:18

Update the function prototype of mhi_ndo_xmit to match
ndo_start_xmit. This otherwise leads to run time failures when
CFI is enabled in kernel.

Fixes: 3ffec6a14f24 ("net: Add mhi-net driver")
Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>
---
 drivers/net/mhi/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 64af1e5..bbbbf6c 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -56,7 +56,7 @@ static int mhi_ndo_stop(struct net_device *ndev)
 	return 0;
 }
 
-static int mhi_ndo_xmit(struct sk_buff *skb, struct net_device *ndev)
+static netdev_tx_t mhi_ndo_xmit(struct sk_buff *skb, struct net_device *ndev)
 {
 	struct mhi_net_dev *mhi_netdev = netdev_priv(ndev);
 	const struct mhi_net_proto *proto = mhi_netdev->proto;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH net] net: mhi_net: Update the transmit handler prototype

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-14 21:20:05

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 14 Jun 2021 15:03:25 -0600 you wrote:
Update the function prototype of mhi_ndo_xmit to match
ndo_start_xmit. This otherwise leads to run time failures when
CFI is enabled in kernel.

Fixes: 3ffec6a14f24 ("net: Add mhi-net driver")
Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>

[...]
Here is the summary with links:
  - [net] net: mhi_net: Update the transmit handler prototype
    https://git.kernel.org/netdev/net/c/2214fb53006e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help