[PATCH] bpftool: Add sock_release help info for cgroup attach command

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [tooling] (bpftool), the rest

STALE1902d

3 messages, 2 authors, 2021-05-24 · open the first message on its own page

[PATCH] bpftool: Add sock_release help info for cgroup attach command

From: Liu Jian <hidden>
Date: 2021-05-24 07:13:57

Fixes: db94cc0b4805 ("bpftool: Add support for BPF_CGROUP_INET_SOCK_RELEASE")
Signed-off-by: Liu Jian <redacted>
---
 tools/bpf/bpftool/cgroup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c
index d901cc1b904a..6e53b1d393f4 100644
--- a/tools/bpf/bpftool/cgroup.c
+++ b/tools/bpf/bpftool/cgroup.c
@@ -28,7 +28,8 @@
 	"                        connect6 | getpeername4 | getpeername6 |\n"   \
 	"                        getsockname4 | getsockname6 | sendmsg4 |\n"   \
 	"                        sendmsg6 | recvmsg4 | recvmsg6 |\n"           \
-	"                        sysctl | getsockopt | setsockopt }"
+	"                        sysctl | getsockopt | setsockopt |\n"	       \
+	"                        sock_release }"
 
 static unsigned int query_flags;
 
-- 
2.17.1

Re: [PATCH] bpftool: Add sock_release help info for cgroup attach command

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-05-24 07:21:07

On Mon, May 24, 2021 at 03:15:48PM +0800, Liu Jian wrote:
Fixes: db94cc0b4805 ("bpftool: Add support for BPF_CGROUP_INET_SOCK_RELEASE")
Signed-off-by: Liu Jian <redacted>
---
 tools/bpf/bpftool/cgroup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
I know I do not take patches without any changelog text, maybe other
maintainers are more leniant...

RE: [PATCH] bpftool: Add sock_release help info for cgroup attach command

From: liujian (CE) <hidden>
Date: 2021-05-24 07:34:42

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Monday, May 24, 2021 3:21 PM
To: liujian (CE) <redacted>
Cc: ast@kernel.org; daniel@iogearbox.net; andrii@kernel.org; kafai@fb.com;
songliubraving@fb.com; yhs@fb.com; john.fastabend@gmail.com;
kpsingh@kernel.org; quentin@isovalent.com; sdf@google.com;
netdev@vger.kernel.org; bpf@vger.kernel.org
Subject: Re: [PATCH] bpftool: Add sock_release help info for cgroup attach
command

On Mon, May 24, 2021 at 03:15:48PM +0800, Liu Jian wrote:
quoted
Fixes: db94cc0b4805 ("bpftool: Add support for
BPF_CGROUP_INET_SOCK_RELEASE")
Signed-off-by: Liu Jian <redacted>
---
 tools/bpf/bpftool/cgroup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
I know I do not take patches without any changelog text, maybe other
maintainers are more leniant...
Sorry, I will send v2 for the bad habits.  Thank you ~
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help