# Re: \[RFC PATCH v6 02/27\] nvme-fabrics: Move NVMF\_ALLOWED\_OPTS and NVMF\_REQUIRED\_OPTS definitions

- From: Hannes Reinecke \<hare@suse.de\>
- Date: 2021-05-28 11:11:12 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/05/6570296
- Thread: https://ratatoskr.run/netdev/2021/05/6570268/t.md

```text
On 5/28/21 1:58 AM, Shai Malin wrote:
> From: Arie Gershberg <redacted>
> 
> Move NVMF_ALLOWED_OPTS and NVMF_REQUIRED_OPTS definitions
> to header file, so it can be used by the different HW devices.
> 
> NVMeTCP offload devices might have different limitations of the
> allowed options, for example, a device that does not support all the
> queue types. With tcp and rdma, only the nvme-tcp and nvme-rdma layers
> handle those attributes and the HW devices do not create any limitations
> for the allowed options.
> 
> An alternative design could be to add separate fields in nvme_tcp_ofld_ops
> such as max_hw_sectors and max_segments that we already have in this
> series.
> 
> Acked-by: Igor Russkikh <redacted>
> Signed-off-by: Arie Gershberg <redacted>
> Signed-off-by: Prabhakar Kushwaha <redacted>
> Signed-off-by: Omkar Kulkarni <redacted>
> Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
> Signed-off-by: Ariel Elior <redacted>
> Signed-off-by: Shai Malin <redacted>
> Reviewed-by: Himanshu Madhani <redacted>
> Acked-by: Sagi Grimberg <sagi@grimberg.me>
> ---
>  drivers/nvme/host/fabrics.c | 7 -------
>  drivers/nvme/host/fabrics.h | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		        Kernel Storage Architect
hare@suse.de			               +49 911 74053 688
SUSE Software Solutions Germany GmbH, 90409 Nürnberg
GF: F. Imendörffer, HRB 36809 (AG Nürnberg)
```