Re: [PATCH 2/3] can: c_can: add ethtool support
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-05-10 13:50:18
Also in:
linux-can, lkml
On 09.05.2021 14:43:08, Dario Binacchi wrote:
With commit 132f2d45fb23 ("can: c_can: add support to 64 message objects")
the number of message objects used for reception / transmission depends
on FIFO size.
The ethtools API support allows you to retrieve this info. Driver info
has been added too.+static const struct ethtool_ops c_can_ethtool_ops = {
+ .get_drvinfo = c_can_get_drvinfo,
+ .get_channels = c_can_get_channels,
+};I think you're filling the wrong information here. I think channels is for independent RX/TX channels. I think you want to implement get_ringparam. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachments
- signature.asc [application/pgp-signature] 488 bytes