[PATCH] ipv6: netfilter.c: fix missing line after declaration

Subsystems: netfilter, networking [general], the rest

STALE1927d

2 messages, 2 authors, 2021-05-05 · open the first message on its own page

[PATCH] ipv6: netfilter.c: fix missing line after declaration

From: Pallavi Prabhu <hidden>
Date: 2021-05-05 19:20:17

Fixed a missing line after a declaration for proper coding style.

Signed-off-by: Pallavi Prabhu <redacted>
---
 net/ipv6/netfilter.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index ab9a279dd6d4..7b1671f48593 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
 
 	if (entry->state.hook == NF_INET_LOCAL_OUT) {
 		const struct ipv6hdr *iph = ipv6_hdr(skb);
+
 		if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
 		    !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
 		    skb->mark != rt_info->mark)
-- 
2.25.1

Re: [PATCH] ipv6: netfilter.c: fix missing line after declaration

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2021-05-05 22:41:29

Hi Pallavi,

On Thu, May 06, 2021 at 12:50:07AM +0530, Pallavi Prabhu wrote:
Fixed a missing line after a declaration for proper coding style.
I'd probably suggest to use Coccinelle or similar to make a Netfilter
tree wide patch to add line after a declaration.

Probably there are more spots in the Netfilter codebase that can
benefit from this cleanup.
quoted hunk
Signed-off-by: Pallavi Prabhu <redacted>
---
 net/ipv6/netfilter.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index ab9a279dd6d4..7b1671f48593 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -81,6 +81,7 @@ static int nf_ip6_reroute(struct sk_buff *skb,
 
 	if (entry->state.hook == NF_INET_LOCAL_OUT) {
 		const struct ipv6hdr *iph = ipv6_hdr(skb);
+
 		if (!ipv6_addr_equal(&iph->daddr, &rt_info->daddr) ||
 		    !ipv6_addr_equal(&iph->saddr, &rt_info->saddr) ||
 		    skb->mark != rt_info->mark)
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help