[PATCH net 1/1] net: stmmac: Clear receive all(RA) bit when promiscuous mode is off

Subsystems: networking drivers, stmmac ethernet driver, the rest

STALE1921d

2 messages, 2 authors, 2021-05-04 · open the first message on its own page

[PATCH net 1/1] net: stmmac: Clear receive all(RA) bit when promiscuous mode is off

From: Ramesh Babu B <hidden>
Date: 2021-05-04 04:39:26

From: Ramesh Babu B <redacted>

In promiscuous mode Receive All bit is set in GMAC packet filter register,
but outside promiscuous mode Receive All bit is not cleared,
which resulted in all network packets are received when toggle (ON/OFF)
the promiscuous mode.

Fixes: e0f9956a3862 ("net: stmmac: Add option for VLAN filter fail queue enable")
Signed-off-by: Ramesh Babu B <redacted>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index 95864f014ffa..f35c03c9f91e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -642,6 +642,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
 	value &= ~GMAC_PACKET_FILTER_PCF;
 	value &= ~GMAC_PACKET_FILTER_PM;
 	value &= ~GMAC_PACKET_FILTER_PR;
+	value &= ~GMAC_PACKET_FILTER_RA;
 	if (dev->flags & IFF_PROMISC) {
 		/* VLAN Tag Filter Fail Packets Queuing */
 		if (hw->vlan_fail_q_en) {
-- 
2.17.1

Re: [PATCH net 1/1] net: stmmac: Clear receive all(RA) bit when promiscuous mode is off

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-05-04 19:10:13

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue,  4 May 2021 21:12:41 +0530 you wrote:
From: Ramesh Babu B <redacted>

In promiscuous mode Receive All bit is set in GMAC packet filter register,
but outside promiscuous mode Receive All bit is not cleared,
which resulted in all network packets are received when toggle (ON/OFF)
the promiscuous mode.

[...]
Here is the summary with links:
  - [net,1/1] net: stmmac: Clear receive all(RA) bit when promiscuous mode is off
    https://git.kernel.org/netdev/net/c/4c7a94286ef7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help