# RE: \[PATCH net-next 2/2\] net: stmmac: Add callbacks for DWC xpcs Energy Efficient Ethernet

- From: Sit, Michael Wei Hong \<hidden\>
- Date: 2021-05-19 02:27:23 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/05/1382764
- Thread: https://ratatoskr.run/netdev/2021/05/1379383/t.md

```text


> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Tuesday, 18 May, 2021 6:06 PM
> To: Sit, Michael Wei Hong <redacted>
> Cc: Jose.Abreu@synopsys.com; andrew@lunn.ch;
> hkallweit1@gmail.com; kuba@kernel.org;
> netdev@vger.kernel.org; peppe.cavallaro@st.com;
> alexandre.torgue@foss.st.com; davem@davemloft.net;
> mcoquelin.stm32@gmail.com; Voon, Weifeng
> [ref]; Ong, Boon Leong
> [ref]; Tan, Tee Min
> [ref]; vee.khee.wong@linux.intel.com;
> Wong, Vee Khee [ref]; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 2/2] net: stmmac: Add callbacks for
> DWC xpcs Energy Efficient Ethernet
> 
> On Mon, May 17, 2021 at 11:37:12AM +0000, Sit, Michael Wei
> Hong wrote:
> > > From: Russell King <linux@armlinux.org.uk>
> > >
> > > On Mon, May 17, 2021 at 05:43:32PM +0800, Michael Sit Wei
> Hong
> > > wrote:
> > > > Link xpcs callback functions for MAC to configure the xpcs
> EEE
> > > feature.
> > > >
> > > > The clk_eee frequency is used to calculate the
> > > MULT_FACT_100NS. This
> > > > is to adjust the clock tic closer to 100ns.
> > > >
> > > > Signed-off-by: Michael Sit Wei Hong
> > > [ref]
> > >
> > > What is the initial state of the EEE configuration before the
> first
> > > call to stmmac_ethtool_op_set_eee()? Does it reflect the
> default EEE
> > > settings?
> >
> > The register values before the first call are the default reset
> values
> > in the registers. The reset values assumes the clk_eee_i time
> period
> > is 10ns, Hence, the reset value is set to 9.
> > According to the register description, This value should be
> programmed
> > such that the clk_eee_i_time_period * (MULT_FACT_100NS + 1)
> should be
> > within 80 ns to 120 ns.
> >
> > Since we are using a fixed 19.2MHz clk_eee, which is 52ns, we
> are
> > setting the value to 1.
> 
> Does that hardware default configuration match what is returned
> by ethtool --show-eee ?

May I know what is the hardware default configuration that is expected
to be returned by ethtool --show-eee?
The MULT_FACT_100NS value is an internal register setting not meant
to be exposed to userspace, and only relevant when EEE is enabled.
> 
> --
> RMK's Patch system:
> https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at
> last!
```